shift-org / shift-docs

Website + calendar for the shift organization
https://shift2bikes.org
Other
22 stars 14 forks source link

Update to latest Node v20.x version #752

Open carrythebanner opened 1 week ago

carrythebanner commented 1 week ago

We're a couple of patch versions behind — review the changelog, check for an updated Docker image, and update:

https://nodejs.org/en/about/previous-releases https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md https://hub.docker.com/_/node/tags

ionous commented 1 week ago

i wasn't sure if maybe we wanted to stick with the lts version or not? ( though i guess, if so we should probably all be pinned to the same version for local dev; so not sure. ) i also noticed, installing on a new machine, many of the libraries have minor version changes. ( can be seen by running npm i --package-lock-only and then checking the package-lock.json )

carrythebanner commented 1 week ago

Somewhat confusingly, I think they just designate the major version as LTS rather than a specific minor/patch version. So v20 is a sort of rolling LTS, with the most recent minor/patch version taking over the older ones. https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md shows each minor/patch version within v20 as an LTS release.

ionous commented 4 days ago

oh. gotcha. i was misreading. you're right: their edge version is actually 22. upgrading to the latest 20 i think makes sense.

carrythebanner commented 13 hours ago

Been doing some local testing with v20.15.0, no issues observed so far.