shiftkey / desktop

Fork of GitHub Desktop to support various Linux distributions
MIT License
6.76k stars 512 forks source link

Incompatibility with KDE Wallet Manager (KWallet) #940

Open Beanazril opened 11 months ago

Beanazril commented 11 months ago

The feature request

GitHub Desktop works by default with gnome-keyring, and installs it and uses it even on devices already using kdewallet and KWallet by default.

Proposed solution

Github Desktop should either:

Additional context

I'm using Ubuntu 22.04 and had great difficulty what was wrong with my keyrings. I had only KWalletManager to open my keyrings, and this didn't show me the "Default keyring" GitHub Desktop was using on gnome-keyring. By all means the "Default keyring" was inivisble. I had to realise that GitHub Desktop installed gnome-keyring and was using this instead of kdewallet, then install seahorse, then delete the "Default keyring" beacause I didn't know the password for it. This was very frustrating and to my understanding, it should be what happens normally to KDE users who never used gnome-keyring.

shiftkey commented 11 months ago

Create and use a default keyring in kdewallet instead if it is already the default keyring manager

We use libsecret for interacting with the credential store, with gnome-keyring having supported that for years it became our default. I'd happily use KWallet if that supports libsecret and it seems to have landed earlier this year https://github.com/shiftkey/desktop/issues/759#issuecomment-1493468916

I'm not sure when I'll have time to setup a KDE machine and test this support but if this seems to work then I'm open to figuring out how to express "either gnome-keying or kwallet" in the packaging dependencies.