shikha-16 / Women-in-Technology

A collection of resources for women in tech, consisting of - courses, learning guides, amazing sites and repos, blogs, programs and events. scholarships, etc.

https://women-in-technology-wit.web.app/

MIT License

715 stars 159 forks source link

Warnings due to unknown p tag #178

Closed sungod12 closed 2 years ago

sungod12 commented 2 years ago

Pull Request Template

Description

-solved error by updating scholarship component due to not closing p tag

Fixes # 174

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My contribution follows the style guidelines of this project
[x] I have performed a self-review of my own contribution
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

sungod12 commented 2 years ago

Check now @nehakalbande @shikha-16 .

sungod12 commented 2 years ago

There could be conflicts again,if you merge my commit after other commits due to some other changes.

shikha-16 commented 2 years ago

@sungod12 hey, we had already solved this after reverting your PR and then notified you to make a new PR. did you pull the repo before opening this PR? because this issue wasn't there then.

sungod12 commented 2 years ago

@sungod12 hey, we had already solved this after reverting your PR and then notified you to make a new PR. did you pull the repo before opening this PR? because this issue wasn't there then.

Wait,i didnt get it.So you solved the issue due to that p tag?

sungod12 commented 2 years ago

@sungod12 hey, we had already solved this after reverting your PR and then notified you to make a new PR. did you pull the repo before opening this PR? because this issue wasn't there then.

Wait,i didnt get it.So you solved the issue due to that p tag?

if it is already solved,then for what issue should i make a pull request?

shikha-16 commented 2 years ago

@sungod12 hey, we had already solved this after reverting your PR and then notified you to make a new PR. did you pull the repo before opening this PR? because this issue wasn't there then.

Wait,i didnt get it.So you solved the issue due to that p tag?

if it is already solved,then for what issue should i make a pull request?

for the image links colour your previous PR for image links colour was causing a problem, so we reverted that and fixed the problem now you should pull the repo, and make a new PR for the links colour

sungod12 commented 2 years ago

@sungod12 hey, we had already solved this after reverting your PR and then notified you to make a new PR. did you pull the repo before opening this PR? because this issue wasn't there then.

Wait,i didnt get it.So you solved the issue due to that p tag?

if it is already solved,then for what issue should i make a pull request?

for the image links colour your previous PR for image links colour was causing a problem, so we reverted that and fixed the problem now you should pull the repo, and make a new PR for the links colour

What was the problem and what should I write in new pull request.?

sungod12 commented 2 years ago

cannot create new pull request.