search

shikijs / twoslash

You take some Shiki, add a hint of TypeScript compiler, and 🎉 incredible static code samples
https://shikijs.github.io/twoslash/
MIT License
1.06k stars 51 forks source link

Use Fenceparser #81

Closed frencojobs closed 3 years ago

frencojobs commented 3 years ago

Closes #77

changeset-bot[bot] commented 3 years ago

🦋 Changeset detected

Latest commit: 8a0fcc0769bc1448521537a0d2615dfbdb724f57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | -------------------------------- | ----- | | shiki-twoslash | Patch | | eleventy-plugin-shiki-twoslash | Patch | | hexo-shiki-twoslash | Patch | | markdown-it-shiki-twoslash | Patch | | remark-shiki-twoslash | Major | | docusaurus-preset-shiki-twoslash | Patch | | gatsby-remark-shiki-twoslash | Patch | | twoslash-cli | Patch | | vuepress-plugin-shiki-twoslash | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

frencojobs commented 3 years ago

Hi @orta. Help pls. I don't know what's wrong with my pnpm but when I installed the fenceparser package, it updates the lock file breaking the links. It not only add the fencerparser to the pnpm-lock.yaml but also turns every link:../packages into versions. I couldn't even test a thing because it just won't work. So I didn't even commit the lockfile. Could you please update the lock file for me so I can at least test or build things? Thanks.

orta commented 3 years ago

I think this is my fault, trying running node scripts/syncVersions.js and re-run. I think the deploy script might need to run that after it is complete.

orta commented 3 years ago

I fixed main and merged that in instead

frencojobs commented 3 years ago

Great! Now only one test is failing. Nice.