search

shimming-toolbox / shimming-toolbox-matlab

Code for performing real-time shimming using external MRI shim coils
GNU General Public License v3.0
16 stars 5 forks source link

Add B1 shimming related functions to +imutils package #147

Open gaspardcereza opened 4 years ago

gaspardcereza commented 4 years ago

Context

We want the shimming toolbox to handle B0 and B1 shimming. So far, only B0 shimming was performed but I'm currently working on finding a way to include RF shimming features as we refactor our code.

Objectives

Add functions to perform B1 mapping and shimming to the +imutils package (under +imutils/+b1). These functions will have to be documented following the convention that will be defined in #133. Unit tests and testing data must also be provided.

jcohenadad commented 4 years ago

i would suggest to use lowercase, i.e. +imutils/+b1, as also done for the +b0 package https://github.com/shimming-toolbox/shimming-toolbox/pull/125/files

gaspardcereza commented 4 years ago

i would suggest to use lowercase, i.e. +imutils/+b1, as also done for the +b0 package https://github.com/shimming-toolbox/shimming-toolbox/pull/125/files

I thought you once said that b0 could be misguiding because it could also refer to another term (I can't find the comment though so maybe I just dreamed about it).

jcohenadad commented 4 years ago

i would suggest to use lowercase, i.e. +imutils/+b1, as also done for the +b0 package https://github.com/shimming-toolbox/shimming-toolbox/pull/125/files

I thought you once said that b0 could be misguiding because it could also refer to another term (I can't find the comment though so maybe I just dreamed about it).

indeed, in the MRI community "b0" often refers to the b-value =0 in DWI experiments. However, in this context, there should not be too much confusion (it is clear we talk about static B0 field), and i find the pros more appealing: