shimming-toolbox / shimming-toolbox-matlab

Code for performing real-time shimming using external MRI shim coils
GNU General Public License v3.0
16 stars 5 forks source link

Numerical model with extended deltaB0 capabilities #152

Closed evaalonsoortiz closed 4 years ago

evaalonsoortiz commented 4 years ago

This PR will address issue #151.

@jcohenadad I would like to know if the source code for phantom3d.m can be included in our toolbox. All that is stated in the license.txt file is that, it (the file) should be included in any distribution of the code. It seems to me that we can. Could you confirm?

jcohenadad commented 4 years ago

@jcohenadad I would like to know if the source code for phantom3d.m can be included in our toolbox. All that is stated in the license.txt file is that, it (the file) should be included in any distribution of the code. It seems to me that we can. Could you confirm?

this code is distributed under the LGPL3 license, stating that "Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.", so as long as the code is not modified (and the license+copyright is mentioned, which is the case), then it should be fine.

another consideration, is that LGPL3 is a less permissive license than e.g. MIT, BSD, meaning that our license should be as restrictive (or more) than LGPL3. Fortunately, shimming-toolbox license is also LGPL3, so no problem here.

evaalonsoortiz commented 4 years ago

This PR is now ready to be reviewed.

NumericalModel.m can now be used to generate simulated T2* decay data for a cylindrical volume, a spherical volume, a 2D or 3D Shepp-Logan phantom, or a "modified" Zubal phantom (the orignial zubal phantom can be found here: http://noodle.med.yale.edu/zubal/data.htm).

A linear deltaB0 field can be simulated or loaded from an external file.