search

shimming-toolbox / shimming-toolbox-matlab

Code for performing real-time shimming using external MRI shim coils
GNU General Public License v3.0
16 stars 5 forks source link

Rt/issue75 shim specs json #92

Open rtopfer opened 4 years ago

rtopfer commented 4 years ago

This PR serves to close #75 — replacing ShimSpecs subclasses with .json files.

This is an initial step toward refactoring the way shim systems are currently represented in the code base: Once completed, a minor refactor of the currently abstract ShimOpt class should allow us to dispense with several (if not all) of the ShimOpt child classes, thereby simplifying the code base and making it very easy to define new shim systems as only the calibration maps and .json file should then be required!

jaystock commented 4 years ago

For SMS acquisitions, would it make sense to explicitly store the slice ordering and slice group information in the .json file? This information is in the twix meas.dat header, but I think it's also buried in the DICOM header, though it might not be parsed by normal DICOM header header scripts in Matlab.

jcohenadad commented 4 years ago

For SMS acquisitions, would it make sense to explicitly store the slice ordering and slice group information in the .json file? This information is in the twix meas.dat header, but I think it's also buried in the DICOM header, though it might not be parsed by normal DICOM header header scripts in Matlab.

Excellent idea. @rtopfer or @po09i can you look if already done by dcm2niix and if not, open an issue on their repos and document here via new issue. Thx