search

shinebayar-g / ufw-docker-automated

Manage docker containers firewall with UFW!
Apache License 2.0
198 stars 31 forks source link

Added build && release automation using github actions #26

Closed shikharvashistha closed 3 years ago

shikharvashistha commented 3 years ago

@shinebayar-g Fixed : #20 && #21

Reference here

shinebayar-g commented 3 years ago

Hi. Thanks for the PR. Continuous build LGTM. Release workflow needs more updates. It has to do the following:

If you want to make updates to the release or just want to merge build only changes in this PR, please do whatever suits you. Either will work. :)

shikharvashistha commented 3 years ago

Hi. Thanks for the PR. Continuous build LGTM. Release workflow needs more updates. It has to do the following:

  • Do everything in the build
  • Create new GH release
  • Upload build binary to the assets of the GH release
  • Body text has to be dynamically generated or just empty for now.

If you want to make updates to the release or just want to merge build only changes in this PR, please do the accordingly. Either will work. :)

Okay, I would like to work on release workflow later and want to merge the CI build for now. Should I rebase or create a new PR what would suit you better I'll proceed accordingly ?

shinebayar-g commented 3 years ago

You can just update this PR, rebase & force push with only build changes should work.

shikharvashistha commented 3 years ago

You can just update this PR, rebase & force push with only build changes should work.

Done !