search

shinken-monitoring / mod-webui

Shinken Web User Interface
GNU Affero General Public License v3.0
79 stars 71 forks source link

Problems not showing counted errors on Dashboard #617

Closed bmalynovytch closed 6 years ago

bmalynovytch commented 6 years ago

There's a misleading information on the Dashboard indicating the number of "problems". Clicking on the counter (or the Problems link /problems in the main menu) then redirects to a custom filter. This filter doesn't have the same amount of "problems" because of "soft" states being excluded.

This PR changes the behaviour of the problems link, to include "soft" states, in accordance with the Dashboard counter.

jmleoni commented 6 years ago

It also contains a fix on the stats module, so it works based on shinken notifications via slack (any notification command that matches /notify-service-by-slack/ will be taken into account.

maethor commented 6 years ago

Hi @jmleoni and @bmalynovytch

I agree with your commits. But why did you merge them in one pull request?

Anyway, I merge, thank you. I will keep you posted when this is released.

maethor commented 6 years ago

I'm sorry @bmalynovytch but merging was a mistake. Not displaying SOFT problems is intentional. I will update the dashboard counter to exclude SOFT states.