search

shinken-monitoring / mod-webui

Shinken Web User Interface
GNU Affero General Public License v3.0
79 stars 71 forks source link

WiP: Some source code cleanings #623

Closed mohierf closed 6 years ago

mohierf commented 6 years ago

Using pycodestyle and pylint to make some cleanings. Added a travis.yml file to run the analysis in the CI Note that all the code is not full compliant but the most important raised errors are still fixed.

Also removed the Alignak backend experimental REST API interface because it is not functional!

maethor commented 6 years ago

Hello @mohierf

Is it all the cleanup you plan to do, or should I expect more PR of the same type in the future? I agree webui code is not uniform and could do with a lot of cleanup. I would love to blacken it for instance. But I don't think it is worth losing all git blame to cleanup the code. What do you think ?

I believe if you are pushing unit tests, they should be OK and not failing :)

mohierf commented 6 years ago

For sure @maethor much more cleanings should be necessary. But I will not go further than the modifications I still did in this PR. I did no yet finished my testsand I will inform you when you can merge this code, but not yet :wink:

mohierf commented 6 years ago

Replaced with #628