search

shinken-monitoring / mod-webui

Shinken Web User Interface
GNU Affero General Public License v3.0
79 stars 71 forks source link

Clean element details view: #683

Closed mohierf closed 5 years ago

mohierf commented 5 years ago
maethor commented 5 years ago

@mohierf I'm ok with this PR. You can resolv the conflit and merge it yourself.

mohierf commented 5 years ago

@maethor: ok. I will rebase on develop, fix the conflict and merge into develop

maethor commented 5 years ago

I get an error 500 in elt view. I revert this PR. Sorry.

Please be careful. I understand you want to improve the webui but I really don't have time to play with that kind of stuff right now…

mohierf commented 5 years ago

Which 500 Error ? A screen capture please ...

maethor commented 5 years ago

I do not have detail, just error 500.

I tryied to enable debug mode to have stack trace but it does not seem to work.

mohierf commented 5 years ago

For debug mode, you must set the SHINKEN_UI_DEBUG environment variable ... in /etc/init.d/shinken:

export SHINKEN_UI_DEBUG=1
maethor commented 5 years ago

Oh, OK. I will test it tomorrow morning.

Le 18/12/17 23:28, Frédéric MOHIER a écrit :

For debug mode, you must set the SHINKEN_UI_DEBUG environment variable ... in /etc/init.d/shinken:

export SHINKEN_UI_DEBUG=1

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/shinken-monitoring/mod-webui/pull/683#issuecomment-448123044

-- Guillaume Subiron Mail - maethor@subiron.org GPG - 5BC2 EADB MSTDN - @maethor@mstdn.fr IRC - maethor@(freenode|geeknode)

maethor commented 5 years ago 
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/usr/local/lib/python2.7/dist-packages/bottle.py", line 1732, in wrapper
    rv = callback(*a, **ka)
  File "/var/lib/shinken/modules/webui2/module.py", line 656, in lock_version
    return f(**args)
  File "/usr/local/lib/python2.7/dist-packages/bottle.py", line 3615, in wrapper
    result = func(*args, **kwargs)
  File "/var/lib/shinken/modules/webui2/plugins/eltdetail/eltdetail.py", line 81, in show_service
    configintervallength = vars(configs[0])['interval_length']
TypeError: vars() argument must have __dict__ attribute
maethor commented 5 years ago

OK, my mistake. It is working fine.