about #715 - Githubissues

shinken-monitoring / mod-webui

Shinken Web User Interface

GNU Affero General Public License v3.0

79 stars 71 forks source link

about #715 #716

Open rednach opened 5 years ago

rednach commented 5 years ago

Defining ui-graphite with enabled=0 and this patch make graphs to appear.

mohierf commented 5 years ago

Thanks @rednach for this PR. I will integrate this in my most recent work and keep you informed.

rednach commented 5 years ago

Thanks to you, @mohierf.

In order to get shinken-ui injecting external commands into alignak, I am working in:

to discard default "alignak_endpoint" (alignak arbiter) as target, because arbiter does not push them to scheduler.
to use receiver+web-services... but not changing "alignak_endpoint" (it use it to get alignak status and event logs) , but adding a new module parameter (i.e. alignak_ws=http://127.0.0.1:7773/ws).
to reuse ExternalCommandManager from alignak to decode command string and AlignakConnection from alignak_webui to login(!!) and post the result...

what do you think? better for me just to wait for your next commits?

mohierf commented 5 years ago

@rednach : have a look to the python3 branch in my own repo here: https://github.com/mohierf/mod-webui

I already modified external commands behavior and it looks ok. Moreover this version is compatible with Python 3 !

mohierf commented 5 years ago

@rednach I did some more testings and the module ui-graphite2 is not easily inclmuded by the current WebUI. My most recent push in the python3 branch is not yet fully functional but I will make more tests in the next few days!

rednach commented 5 years ago

@mohierf Now, your python3 branch is working with alignak/develop (or alignak/module_on_module), but yet with the disable/enable trick to load ui-graphite2 (and another patch about "quote", I suppose because I use python 2).

mohierf commented 5 years ago

@rednach: I am still fixing this behaviour. I identified precisely what is the problem but do not have much time at the moment ... I will release an Alignak and WebUI version that ill make the job soon 😉

mohierf commented 5 years ago

@rednach: this morning I pushed a version of the ui-graphite module in a dedicated branch (see https://github.com/mohierf/mod-ui-graphite/tree/python3)

As of now, I am using :

alignak, branch module_on_module
mod-webui, branch python3
mod-ui-graphite, branch python3

And the modules are correctly loaded with Python 3. I did not yet tested that the ui graphite module is fully functional ... but I will od it soon

Note that both modumles are in the repositories on my own github

maethor commented 5 years ago

Hi,

I don't know how to review and merge this commit. Is it still relevant?