search

shinyquagsire23 / OpenJKDF2

A cross-platform reimplementation of JKDF2 in C
Other
523 stars 46 forks source link

[Vanilla Issue] Lightsaber is thinner on initial level load until restart/death. #95

Open Journeyman716 opened 2 years ago

Journeyman716 commented 2 years ago

The lightsaber blade will always appear thinner than it should upon initial level load, until the player either dies and reloads their last save, or restarts the level. Issue exists in the original game as well. Left is initial load, right is restart/death/save load. image Interestingly, manual saves/quicksaves keep the blade properly scaled.

nikumubeki commented 2 years ago

Not a solution, but just for general information, this is a "feature" of vanilla JK. For example, when you start level 4, the saber looks like this (screenshots from vanilla JK under JkGfxMod without any graphical enhancement packs):

jk 2022-10-13 17-12-03-67

But if you die at this point (by using the "kill" command) or restart the level, the "glow" of the saber gets wider as in your screenshots:

jk 2022-10-13 17-12-09-40

With the original 1997 graphics, it's not immediately noticeable, but under OpenJKDF2 or JkGfxMod with their bloom effects, it becomes very apparent.

This is one of the reasons why in my EMJK higher-res graphics mod compilation pack for JK, there are revised lines of code for each of JK's level to (hopefully) ensure that the saber measurements remain the same throughout the game, so that dying and/or restarting (or loading a savegame) wouldn't mess them up. Ultimately it's a quick jerry-rigged fix that works as such only on JK's main SP campaign, of course.

Vortikai commented 2 years ago

For an immediate solution outside of OpenJKDF2, I extracted and uploaded lightsaber fixes @nikumubeki made found here. You can use these for any version, but was made for emissive textures like you have in mind.

Place the contents in your Episode folder in your Jedi Knight directory. I can't remember if I incorporated LOD minmapping fixes as well, as those are also edited on a per level bases in those cogs, but that too can be a QOL improvement. As with any mod, these will probably not work on previous saves.

Edit: The cogs don't contain LOD/mipmap fixes that I think are already in openjkdf2 anyway. The download is just lightsaber proportion fixes.