shipharbor / merry

:ocean::ocean::sailboat::ocean::ocean: - cute streaming API framework
MIT License
312 stars 21 forks source link

Possible breakage on Node 7 #53

Closed yoshuawuyts closed 7 years ago

yoshuawuyts commented 7 years ago

Noticed tests were failing on an app I'm building; not sure what's the cause but we should investigate what changed in core.

screen shot 2017-01-15 at 03 30 01
lrlna commented 7 years ago

ugh :(

i am not that familiar with circle output -- does the build give you any other info we can work?

yoshuawuyts commented 7 years ago

Oh this is Travis (:

On Sun, Jan 15, 2017, 15:13 Irina Shestak notifications@github.com wrote:

ugh :(

i am not that familiar with circle output -- does the build give you any other info we can work?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/issues/53#issuecomment-272697706, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWleh8swBTswF0ls_9i8Cm25r5seceeks5rSimagaJpZM4LjzlD .

lrlna commented 7 years ago

Clearly don't know Travis either lolololol 😂

On Sun, Jan 15, 2017, 15:12 Yoshua Wuyts notifications@github.com wrote:

Oh this is Travis (:

On Sun, Jan 15, 2017, 15:13 Irina Shestak notifications@github.com wrote:

ugh :(

i am not that familiar with circle output -- does the build give you any other info we can work?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/issues/53#issuecomment-272697706, or mute the thread < https://github.com/notifications/unsubscribe-auth/ACWleh8swBTswF0ls_9i8Cm25r5seceeks5rSimagaJpZM4LjzlD

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/issues/53#issuecomment-272701219, or mute the thread https://github.com/notifications/unsubscribe-auth/AHu3CK9EvHoZMeP3b0dh_f3cYnLqfyn1ks5rSjdSgaJpZM4LjzlD .

yoshuawuyts commented 7 years ago

hah, yeah so this is fine (: just don't use null as the first arg in .listen()