Closed lrlna closed 7 years ago
oh lol bahhhh ofc facepalm
On Sun, 22 Jan 2017 at 13:31 Yoshua Wuyts notifications@github.com wrote:
@yoshuawuyts requested changes on this pull request.
we need more math
In index.js https://github.com/yoshuawuyts/merry/pull/56#pullrequestreview-17828629:
@@ -80,6 +80,12 @@ Merry.prototype.router = function (opts, routes) { var statusCode = err.output.statusCode || (res.statusCode >= 400 ? res.statusCode : 500)
- if (statusCode === 400) {
this won't work if we hit something like a 401
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#pullrequestreview-17828629, or mute the thread https://github.com/notifications/unsubscribe-auth/AHu3CL8viWPPk4sZtBm-8p0CQ-eKYc4Cks5rU1oggaJpZM4LqYEw .
Did you cut a release for this too btw?
On Wed, Feb 1, 2017, 13:54 Irina Shestak notifications@github.com wrote:
Merged #56 https://github.com/yoshuawuyts/merry/pull/56.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#event-945526688, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlekSoPZo8jodw1jNnDhVpEq-CbGkZks5rYP8NgaJpZM4LqYEw .
yeppppp it's the 4.1.4 one ✨
On Thu, 2 Feb 2017 at 10:48 Yoshua Wuyts notifications@github.com wrote:
Did you cut a release for this too btw?
On Wed, Feb 1, 2017, 13:54 Irina Shestak notifications@github.com wrote:
Merged #56 https://github.com/yoshuawuyts/merry/pull/56.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#event-945526688, or mute the thread < https://github.com/notifications/unsubscribe-auth/ACWlekSoPZo8jodw1jNnDhVpEq-CbGkZks5rYP8NgaJpZM4LqYEw
.
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#issuecomment-276925299, or mute the thread https://github.com/notifications/unsubscribe-auth/AHu3CD-K6XX7aTpwruecwVxFwoahXWZZks5rYbSNgaJpZM4LqYEw .
Swooooosh
On Thu, Feb 2, 2017, 02:54 Irina Shestak notifications@github.com wrote:
yeppppp it's the [4.1.4](
https://github.com/yoshuawuyts/merry/commit/6826070ffb0ca6d5321202e63c5c658eaa7d9260 ) one ✨
On Thu, 2 Feb 2017 at 10:48 Yoshua Wuyts notifications@github.com wrote:
Did you cut a release for this too btw?
On Wed, Feb 1, 2017, 13:54 Irina Shestak notifications@github.com wrote:
Merged #56 https://github.com/yoshuawuyts/merry/pull/56.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#event-945526688, or mute the thread <
.
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#issuecomment-276925299, or mute the thread < https://github.com/notifications/unsubscribe-auth/AHu3CD-K6XX7aTpwruecwVxFwoahXWZZks5rYbSNgaJpZM4LqYEw
.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#issuecomment-276926544, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlelghnMDRPX8fz6dhmwu0DANhSkXMks5rYbXrgaJpZM4LqYEw .
🏄🌊🌊 🌊🌊🌊
On Thu, Feb 2, 2017, 11:09 Yoshua Wuyts notifications@github.com wrote:
Swooooosh
On Thu, Feb 2, 2017, 02:54 Irina Shestak notifications@github.com wrote:
yeppppp it's the [4.1.4](
https://github.com/yoshuawuyts/merry/commit/6826070ffb0ca6d5321202e63c5c658eaa7d9260 ) one ✨
On Thu, 2 Feb 2017 at 10:48 Yoshua Wuyts notifications@github.com wrote:
Did you cut a release for this too btw?
On Wed, Feb 1, 2017, 13:54 Irina Shestak notifications@github.com wrote:
Merged #56 https://github.com/yoshuawuyts/merry/pull/56.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#event-945526688, or mute the thread <
.
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#issuecomment-276925299, or mute the thread <
.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#issuecomment-276926544, or mute the thread < https://github.com/notifications/unsubscribe-auth/ACWlelghnMDRPX8fz6dhmwu0DANhSkXMks5rYbXrgaJpZM4LqYEw
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/pull/56#issuecomment-276929656, or mute the thread https://github.com/notifications/unsubscribe-auth/AHu3CP9EcdGmE0LunlboHk9rY8DhMiqgks5rYbl3gaJpZM4LqYEw .
i am thinking something like this as a fix for #49