Adds the Banshee-class Salvage Clipper [Hardliner]

[Burning02]

About The Pull Request

Adds the Banshee-class Salvage Clipper to the game for the Hardliner faction in-game as pictured below:

StrongDMM screenshots

Screenshot with areas  Screenshot without areas 

A drastic refit of an ICW-era Cybersun yacht into a salvage vessel. While the Banshee retains most of the original exterior, its interior houses an exosuit-based Hardliner salvage team and all the facilities they could need. Though somewhat dated, it functions well as a sleeper ship that could easily be mistaken for any other civilian vessel.

Description revised by @Apogee-dev

Why It's Good For The Game

This adds a new vessel for a faction lacking in not only player spawnable vessels, but also small ships. The only currently available Hardliner vessel (Komodo) was too large for the average Komodo crew of 4, with either semi-important roles missing crew (Engineer, medic, or in some cases 2IC's), or the majority of the crew being one role (Deckhand, trooper).

Changelog

:cl: add: Adds the Banshee-class Salvage Clipper as a playable Hardliner vessel /:cl:

[Apogee-dev]

Remember to post an in-game screenshot and a screenshot of the map in SDMM with areas enabled in the PR body please

[Burning02]

Alright! I'll have those posted soon

[Burning02]

Pictures added as requested

[Apogee-dev]

I think you went a little overkill on the colored exterior lights there. They’re supposed to be imitating navigational beacons on aircraft- You can honestly remove almost all of those and just have one or two on the wingtips, plus the ones on the cargo deck. If the wings are too dark, use floor lights or a more neutral color of beacon. there’s a white one, i think.

Also, regarding the screenshot, remember to turn the lights on! Part of the reason we ask for those is to get a feel of how the ship looks live and lighting is a big thing that doesnt show up in sdmm.

[Anticept]

Funny thing apogee, white is also a restricted light.

Red left, right green, aft white, but internittent use like landing lights can be white too.

Strobes are white too.

[Apogee-dev]

With that out of the way, some design feedback.

• The central hallway is remarkably barren, with no furniture at all outside of the trash can. I’d suggest putting a couple chairs or a corpo couch / bench against the wall somewhere in there. Even if it’s just two tiles of chair it’ll break up the monotony a lot.
• Dorms is similarly very empty, especially near the door. Give them a couch against the back wall or an armchair by the table, maybe!
• The ship in general feels a bit under-decorated; Add some signs and posters (like warning signs near the airlock, no smoking signs in engineering, etc) and clutter objects on tables and the like.
• Cryo has a similar problem with that big empty table, thanks to the locker scooping items up. If you have a wall locker on the same tile as a table, you don’t need a wall locker. Use a standing locker instead, or remove the table for a little more walking room. Maybe put a chair in the corner instead.
• Don’t use those dark iron chairs in canteen please, just use normal ones. The dark ones don’t stand out against the dark floor and don’t match the table.
• Please don’t put shutters over your external airlock. Enable ship access on the outer door if you’re concerned about uninvited guests.
• Speaking of the airlock, airlocks must have 2 passable tiles in sequence so somebody can drag an object through. That one has 2 tiles of internal space but if you walk into that second tile dragging something you’ll trap yourself. I’d suggest moving one of the doors one tile to the side and including a window to put the layer manifold under. It also needs an emergency space suit and some oxygen; on a tiny ship like this, you can put those in a wall emergency closet.

[Apogee-dev]

Funny thing apogee, white is also a restricted light.

Red left, right white, aft white, but internittent use like landing lights can be white too.

Strobes are white too.

I think the reason I used green was probably because I was thinking of boats, which use those a bit differently. Red port, green starboard, white on the stern and masthead lights (or all-around light). You’re right though, white would still be restricted. Use yellow, then.

[Anticept]

Funny thing apogee, white is also a restricted light. Red left, right white, aft white, but internittent use like landing lights can be white too. Strobes are white too.

I think the reason I used green was probably because I was thinking of boats, which use those a bit differently. Red port, green starboard, white on the stern and masthead lights (or all-around light). You’re right though, white would still be restricted. Use yellow, then.

Edited, meant to say right is green.

[Burning02]

All feedback addressed in the map, I'll be updating the pictures and PR soonish.

[Sadhorizon]

Hayo. That's a great ship too, honestly.

• Cybersun uses heavy firelocks under these.
• These buttons are hugging. Give them a pixel of breathing room.
• Since when do Hardliners use green? I'd suggest you use black suit vartedited to use -med sprite, since it's white-red-black.
• There is no starting autolathe mats.
• This really does not need three tanks - it's for emergencies, and there is only one suit anyways.
• Random/trash has no spawn list. You are looking for random/trash/garbage.
• I think recolored white curtains would fit better than red/gold fancy ones.
• Cybersun uses the syndicate variant of cryopods.
• Cybersun uses heavy firelocks in airlocks.
• Don't give them a CS stamp. I've talked with Apogee and we've decided that Hardliners should be stampless. I guess generic captain works though?
• Cybersun uses secure holopads, as the cybersecurity company. Switch the var to "secure = 1" and also reflect it in the name.
• Windows in dorms, bridge and engi should get window firelocks.
• That is a Whole Kitchen, but they really don't have a nice kitchen to use it in. I'd reduce the amount by A Lot.
• Anchor your generator.
• I have no idea if GEC and Hardliners should work with each other. Double check with someone who knows please.
• I'd use a metal locker over a cabinet. Fits the vibe better imo.
• Airlock issues. So, how Cybersun does it is: Engi and cargo have freezer doors, Cryo and toilets have public doors (just turn off the var so they aren't actually public).
• Why is this a secure closet what??

[Burning02]

Just a few replies to your review:

Since when do Hardliners use green? I'd suggest you use black suit vartedited to use -med sprite, since it's white-red-black.

There is no starting autolathe mats.

Whoops, forgot to add thoses

This really does not need three tanks - it's for emergencies, and there is only one suit anyways.

Did this when I had woke up so I probably fat fingered the left click, I'll fix that

Cybersun uses heavy firelocks in airlocks.

No, they don't? Atleast not in the one other Cybersun map with an airlock

Don't give them a CS stamp. I've talked with Apogee and we've decided that Hardliners should be stampless. I guess generic captain works though?

Unless Apogee forgot, I asked her in DM's if I could add a Cybersun stamp, and if so which one. They said the virtual solutions stamp.

Anchor your generator.

I've included a wrench and a toolbox to do such if no engineer is present whatsoever

I have no idea if GEC and Hardliners should work with each other. Double check with someone who knows please.

Could've sworn the Hardliner outfit had a GEC alternative? I'll have to double check; And in regards of them working together I have at the very least before Komodo was kill had GEC mechanics pretty commonly although yeah I'll check with a lorehead

Airlock issues. So, how Cybersun does it is: Engi and cargo have freezer doors, Cryo and toilets have public doors (just turn off the var so they aren't actually public).

Haven't had any complaints from Apogee with the specific airlocks I've used. Unless I get complaints from her, I'll keep them as is. Well, save for the cryo one I'll change that one to a public since it does feel out of place.

Why is this a secure closet what??

Whoops, could've sworn I changed that to an emergency locker

Anyhow, I'll get to doing some of the changes.

[Burning02]

Nevermind, I'm mistaken on which Hardliner role has a GEC outfit alternative, it's the miner outfit for whatever odd reason Disregard, I must be seeing things

[Zevotech]

@Sadhorizon The effort is appreciated, but please leave comprehensive reviews to maptainers. Providing conflicting information and styling your review as if the changes are required really isn't helpful. Feedback via discord or short comments is fine, but please refrain from doing this in the future.

[Burning02]

Review addressed in in the last push to the PR