Please review my app

[shivagss]

Please review my app. @nesquena and @thecodepath

[codepathreview]

:+1: Decent work Shiva. A few notes after checking out the code:

• Nice job with including progress circle.
• Good use of view holder pattern inside adapter
• Nice use of tag to setup the ability to click the profile image and view a user's profile
• Nice to see you used the ViewPager to properly setup the tabs!
• The way you have worked with Profile Activity and the way you have setup your tabs, you havent really followed the essential learnings involved in this project
• Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, you have a lot of code duplication
• See communicating with fragments for more details how ProfileActivity should have added a fragment and communicated with it.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

[shivagss]

@nesquena @codepathreview I thought it was important to make the app look closely like Twitter app itself. The profile activity resembles very much like the Twitter app which shows the top 3 tweets and latest photos along with lists of Friends, Followers and Favorites. The assignment goal of re-using the fragment was achieved when you click "View all Tweets" from profile, which calls the newInstance() of the re-usable fragment via the DisplayTweetsListActivity. I originally implemented manually adding the tabs, but the ViewPager seems to be a better approach and once again its what the original Twitter app does.