search

shkcodes / Lyrically

A lyrics app which works everywhere!
MIT License
88 stars 23 forks source link

Translatable preferences #11

Closed toXel closed 7 years ago

toXel commented 7 years ago

The strings in preferences.xml should also be extracted into the strings.xml so they become translatable.

I would do it but I want to ask @shkcodes if this is ok? :slightly_smiling_face:

shkcodes commented 7 years ago

Yep go ahead. I was planning to do this. And thanks a lot for the translations!! Much appreciated.

shkcodes commented 7 years ago

Don't forget to add the German text for the preference strings. Thanks!

shkcodes commented 7 years ago

I've added some more files.

toXel commented 7 years ago

OK nice. But I think it's a better practice to not fill in the "empty translations". That way the translators can't see which strings aren't already translated in the Android Studio Translator. If you just don't add them to the values-XX files the app will load the not translated strings from the main strings.xml so there will be no difference in the app.

I hope you understand my point :smile:

shkcodes commented 7 years ago

Gotcha.