search

shlomiassaf / ngrid

A angular grid for the enterprise
https://shlomiassaf.github.io/ngrid
MIT License
241 stars 40 forks source link

Added the option to select the icon for the matHeaderContextMenuTrigger #154

Closed XephyLon closed 3 years ago

XephyLon commented 3 years ago

There are situations in which we need to change the context menu icon to fit the design choice. For example. using horizontal dots instead of vertical.

Unless I'm unaware of a way that already exists to do that.

shlomiassaf commented 3 years ago

The context menu plugin inside @pebula/ngrid-material is a very simple menu mostly created as an example on how to create such a module for a context menu.

It has a fixed menu list, which is the first thing to extend, if we would like to extend it.

Creating a context menu without the plugin is quite easy

However, if we want to add this one, why limit to the mat-icon? should it be possible to provide a template with the icon, i'm not sure here... I don't know if the purpose of this plugin is to get big because of support

XephyLon commented 3 years ago

It's not about creating the menu as much as it is changing the menu trigger icon to fit with the design specifics.

Actually, limiting it to just mat-icon does sound strange. What would be the best way to have it provide a template instead? I'd like to research and implement that.