search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

remove deep_copy and shallow_copy methods #2130

Open karlnapf opened 10 years ago

karlnapf commented 10 years ago

from CSGObject. We have clone for (truly) deep copies, and the copy constructor should be implemented for shallow ones (documented whats actually happening). These methods are just causing problems due to unstandardised behaviour

srgnuclear commented 9 years ago

I am working on this. deep_copy() was found in CSGObject in SGObject.h : virtual CSGObject *deep_copy() const { SG_NOTIMPLEMENTED return NULL; } what would be the correct approach to deal with it. Should i remove the above completely and compile it ?

karlnapf commented 9 years ago

Let us postpone this until we have made up our mind about the parameter framework.

srgnuclear commented 9 years ago

ohk..

erip commented 9 years ago

@karlnapf Any word on this? I've noticed that shallow_copy is used (a bit) in the code. deep_copy, on the other hand, is both unused in its current state and is used as clone. How should I proceed?

karlnapf commented 8 years ago

Hi @srgnuclear I was away for a while. But back now.

shallow copies can be done via the copy constructor I guess?