shonumi / gbe-plus

DMG/GBC/GBA emulator and experimental NDS emulator.
GNU General Public License v2.0
530 stars 80 forks source link

Modernize the CMake build system #166

Closed randomusername-a closed 8 months ago

randomusername-a commented 8 months ago
shonumi commented 8 months ago

Looks like some good changes. I'll have to test it on some of my machines before merging. Might be a day or two until then.

One thing however, is that GBE+ uses tabs instead of 4 spaces. I dunno if its standard for other projects to use 4 spaces in CMake files, but I'm pretty firm about my preference for tabs.

randomusername-a commented 8 months ago

There were mixed spaces and tabs before my changes. I've replaced them all with tabs now.

shonumi commented 8 months ago

Thanks! I believe those spaces were from outside sources (old copy+pastes and one other contributor), so sometimes they sneak in.

Like I said, I'll test it on my end (Linux and Windows) and merge once it checks out.

randomusername-a commented 8 months ago

Sure, no problem.