search

shopware / app-bundle-symfony

Symfony Bundle for Shopware App Backend
MIT License
12 stars 7 forks source link

ShopEntity should be ShopInterface #17

Closed powli closed 2 years ago

powli commented 2 years ago

Currently, the ShopRepositoryInterface is bound to the ShopEntity, which limits extensibility.

For testing purposes and examples, the ShopEntity is fine, even though it is not an Entity at all in the doctrine/orm sense. For an App starting from the AppTemplate however, it's much more convenient to build the Shop entity using the Doctrine annotations/attributes.

Personally I'd prefer if the Shop class and its repository would be implemented in the AppTemplate repository using the doctrine/orm attributes, while the AppBundle provides the interfaces that need to be implemented to get the quickstart with working registration/confirmation.

SebastianFranze commented 2 years ago

Hey there :)

Thank you for reporting this issue.

Yes, it totally makes sense to have an additional interface for ShopEntities. This would make the bundle more flexible in a way that you can use whatever storage system and orm you like.

We are going to add it