shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
87 stars 18 forks source link

Add connections_opened metric #1754

Closed rukai closed 2 months ago

rukai commented 2 months ago

Opening new connections is quite expensive on kafka, not only do we have to reperform authentication, the new transform instance created for this new connection must fetch its own metadata from kafka. To give visibility into this I have added this connections_opened metric which increments every time a new connection is opened.

The results of this metric on the windsock benchmark: image

We can see that

So we can conclude that the performance issues is not caused by the client creating more connections. I believe this metric should still be added as its helpful for ruling out such possibilities in the future.

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #1754 will not alter performance

Comparing rukai:add_connections_opened_metric (cf37951) with main (4693aab)

Summary

✅ 39 untouched benchmarks