search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
87 stars 18 forks source link

Add integration tests for fetch.min.bytes and fetch.wait.max.ms #1757

Closed rukai closed 2 months ago

rukai commented 2 months ago

Add integration test cases for fetch.min.bytes and fetch.wait.max.ms. We will be implementing logic to adhere to these values in https://github.com/shotover/shotover-proxy/pull/1756 so we want to make sure that we have some coverage of them. This PR can be merged first since we dont have any correctness issues with these values, only performance issues.

Since we have two new fields that we want to be able to configure the consumer with, its time that we refactor connect_consumer to use the builder pattern instead of creating argument soup.

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #1757 will not alter performance

Comparing rukai:min_bytes_tests (88022d7) with main (0eb9ff1)

Summary

✅ 39 untouched benchmarks