search

shotover / shotover-proxy

L7 data-layer proxy
https://docs.shotover.io
Apache License 2.0
87 stars 18 forks source link

KafkaSinkCluster: route ConsumerGroupDescribe request #1826

Closed rukai closed 1 week ago

rukai commented 1 week ago

This PR will remain as draft until https://github.com/shotover/shotover-proxy/pull/1825 is landed. Changes on top of #1825 are in a separate commit.

ConsumerGroupDescribe is a replacement for the existing DescribeGroups message type.

No need to add new integration tests for this PR as we are already hitting this message type in our integration tests, we have avoided implementing this message type in shotover by modifying ApiVersions responses to instruct the client that we do not support ConsumerGroupDescribe. This PR removes the ApiVersions rewrite so that the driver will make use of ConsumerGroupDescribe and then implements routing logic for ConsumerGroupDescribe. ConsumerGroupDescribe requests are split up by group id, like the existing routing logic for message types DeleteGroups, DescribeGroups etc.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #1826 will not alter performance

Comparing rukai:consumer_group_describe (9459ef0) with main (6d73da1)

Summary

✅ 38 untouched benchmarks