search

shower / cli

Command line interface for Shower
Other
35 stars 6 forks source link

Core path update #49

Closed pepelsbey closed 4 years ago

pepelsbey commented 4 years ago

@shower/core is now released as v3.0.0 stable, so I’m currently moving the rest of the packages to the @shower organization. To publish the @shower/shower package I need to update the cli with the new core path first.

Would you mind checking my changes and releasing the new cli version? :)

mrdimidium commented 4 years ago

Hi. Thank you for your contribution.

I'm at work right now, but I'll check and release the update today.

pepelsbey commented 4 years ago

If you don't want to get into the code, I can finish it myself tonight

Huh, too late. Done :)

mrdimidium commented 4 years ago

Oh, and the filename too, please :)

https://github.com/shower/cli/blob/7b9b04be0a663437d4666e911b1b403af5cb7e26/core/lib/presentation.js#L37

pepelsbey commented 4 years ago

Done.

It kinda makes you understand that it’s a bit too much hard-coded ;)

mrdimidium commented 4 years ago

Yes, I agree that it is worth making this dependency more flexible.

mrdimidium commented 4 years ago

I published version 0.3.0 in npm, with your PR.