search

showrav017 / jain-sip

Automatically exported from code.google.com/p/jain-sip
0 stars 0 forks source link

Invalid websocket handshake response in case of fragmentation of request HTTP message #137

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Execute WebSocket handshake initiated by large HTTP request (e.g. large 
amount of data inside "Cookie" header).
2. Client will get "Error during WebSocket handshake: Incorrect 
'Sec-WebSocket-Accept' header valuer"

It is expected to get valid WebSocket Handshake response in case of handshake 
request got fragmented.

Tested on Linux with jain-sip 1.2.210

To fix the problem it necessary update line #142 inside 

https://code.google.com/p/jain-sip/source/browse/src/gov/nist/javax/sip/stack/Ni
oWebSocketMessageChannel.java?name=jain-sip-release-1.2.210

to following: byte[] response = new 
WebSocketHttpHandshake().createHttpResponse(httpInput)

Original issue reported on code.google.com by vyaremc...@twilio.com on 15 Jul 2014 at 6:02

GoogleCodeExporter commented 8 years ago 
Can you provide a non regression test for that ?

Original comment by jean.der...@telestax.com on 11 Aug 2014 at 10:09