Closed shreevatsa closed 2 months ago
I have hide-show working for (chunk) images, but nothing yet for bringing back the line-by-line view. That requires changing the toDOM()
of line
(I guess — though chunk
remains an option, will have to look at the code), so that for a chunk with N lines, there are at any time 1+N image divs on the page, the former with class .chunk-image
(say) and the latter with class .line-image
, and CSS variables for each.
Reopening: what we'd like is:
The current "beside if possible otherwise above" is probably not desired?
Given the current DOM structure:
I guess we could say:
# | Mode | Chunk | Chunk Image | Line Image | Line |
---|---|---|---|---|---|
0 | Reading mode | flex | none | none | inline-flex |
1 | Beside, chunks | flex | block | none | inline-flex |
2 | Beside, lines | flex | none | block | block |
3 | Above, chunks | block | block | none | inline-flex |
4 | Above, lines | block | none | block | block |
The "beside, lines" option has some wonkiness (image gets cut off).
Add to the Prosemirror menu with three options: