search

shripalsoni04 / nativescript-webview-interface

Plugin for bi-directional communication between webView and android/ios
MIT License
88 stars 35 forks source link

Upgrade to Nativescript 7 #57

Closed crechberger closed 3 years ago

crechberger commented 3 years ago

Hey,

Nativescript recenlty introcuded some big changes (for example they changed the compiler option from "ES-5" to "ES2017"). It would be great if you could bring the whole project up to date.

Here's the url with all the instructions: https://nativescript.org/blog/nativescript-7-for-plugin-authors/

Thank you :)

ghost commented 3 years ago

just change the plug-in ( file: index.android.js ) a bit:

line 2 from const platformModule = require("platform"); to const platformModule = require("@nativescript/core");

and

line 78 from if (platformModule.device.sdkVersion >= 19) { to if (platformModule.Device.sdkVersion >= 19) {

shripalsoni04 commented 3 years ago

Fixed in version @1.4.4.

crechberger commented 3 years ago

Thanks :)