shssoichiro / soifunc

Vapoursynth helper utilities
MIT License
9 stars 0 forks source link

Deprecate duplicate functions, update existing ones #6

Closed shssoichiro closed 1 year ago

shssoichiro commented 1 year ago

This PR does the following:

The biggest "drawback" for the common users of this *func is more reliance on iew-related packages. That said, most of the direct iew usage should be mitigated and abstracted away, so it should not require users learn how to use those functions per se (though of course, in my personal opinion, they should lol). The deprecated functions currently work as wrappers around those instead.

Originally by @LightArrowsExe #4; recreated due to git glitchyness.

shssoichiro commented 1 year ago

@Setsugennoao I believe you were advocating for Python backwards compatibility in Discord yesterday. mypy is complaining that enum has no attribute StrEnum and the type stubs seem to indicate that is only available in 3.11. Thoughts/alternatives?

Setsugennoao commented 1 year ago

Welll, that's Light's code 🎉 I have my own CustomStrEnum in vstools, you can just swap it for StrEnum and it's gonna be 3.10 compatible.

shssoichiro commented 1 year ago

I hate mypy so much. 50 false positives for every actual error. It's like how Typescript was in its infancy, except unlike Typescript, mypy doesn't feel like it's gotten any better since the first time I had to use it 4 years ago.