Closed QJvic closed 7 months ago
Fixed In : 13377d3
Maybe this is not the best solution. For example, when we use datePicker and input in a same row, they have different height (the height of input box is 31px).
Fixed In : 13377d3
Maybe this is not the best solution. For example, when we use datePicker and input in a same row, they have different height (the height of input box is 32px).
Yes, you are right.
The CSS
of some components is quite outdated. Although it has been refactored several times, the original code is about 3 years ago.
You must have noticed, In the current structure, I have to explicitly set the height
and width
, which was a notion I didn't think would require so much compatibility when the project was just init.
especially with "input-related" components such as select
and datePicker
, that they all have this kind of issue.
But! We have relevant plans: https://github.com/shuimo-design/shuimo-ui/issues/64
Non-essential : organizing all css, mainly streamlining variables, considering a more elegant way of writing; So relatively speaking, this falls under a 'temporary solution'.
If you have any ideas or suggestions, please make sure to raise them. We really need some discussion!
Fixed In : 13377d3
Maybe this is not the best solution. For example, when we use datePicker and input in a same row, they have different height (the height of input box is 32px).
Yes, you are right. The
CSS
of some components is quite outdated. Although it has been refactored several times, the original code is about 3 years ago. You must have noticed, In the current structure, I have to explicitly set theheight
andwidth
, which was a notion I didn't think would require so much compatibility when the project was just init. especially with "input-related" components such asselect
anddatePicker
, that they all have this kind of issue. But! We have relevant plans: #64Non-essential : organizing all css, mainly streamlining variables, considering a more elegant way of writing; So relatively speaking, this falls under a 'temporary solution'.
If you have any ideas or suggestions, please make sure to raise them. We really need some discussion!
As far as this issue is concerned, I think it's more appropriate to set the overflow
of the wrap box to hidden
than to modify the height.
As far as this issue is concerned, I think it's more appropriate to set the
overflow
of the wrap box tohidden
than to modify the height.
In some of my ancient memories, hiding inputs with overflow feels like "playing hooky"
, potentially causing issues in certain scenarios. However, I've tested several scenarios and it seems there are no problems.
Anyway, your solution is better and more elegant;
I fixed it.
🐞 Bug Report
If you are absolutely certain that this is a
bug
and you are able and willing to submit aPR
, please do so.📢 Describe the bug
Datepicker has inner scrollBar