shuimo-design / shuimo-ui

一款水墨风UI
https://shuimo.design
MIT License
282 stars 24 forks source link

[🐞 Datepicker] has inner scrollBar #75

Closed QJvic closed 7 months ago

QJvic commented 7 months ago

🐞 Bug Report

请尽可能使用英文描述问题,或者是提供中英文双语描述(机翻也没有关系),便于后来者检索问题。

If you are absolutely certain that this is a bug and you are able and willing to submit a PR, please do so.

📢 Describe the bug

Datepicker has inner scrollBar

image
higuaifan commented 7 months ago

Fixed In : https://github.com/shuimo-design/shuimo-ui/commit/13377d3541b78b2f0848299ab0efaa60f1a312d5

QJvic commented 7 months ago

Fixed In : 13377d3

Maybe this is not the best solution. For example, when we use datePicker and input in a same row, they have different height (the height of input box is 31px).

higuaifan commented 7 months ago

Fixed In : 13377d3

Maybe this is not the best solution. For example, when we use datePicker and input in a same row, they have different height (the height of input box is 32px).

Yes, you are right. The CSS of some components is quite outdated. Although it has been refactored several times, the original code is about 3 years ago. You must have noticed, In the current structure, I have to explicitly set the height and width, which was a notion I didn't think would require so much compatibility when the project was just init. especially with "input-related" components such as select and datePicker, that they all have this kind of issue. But! We have relevant plans: https://github.com/shuimo-design/shuimo-ui/issues/64

Non-essential : organizing all css, mainly streamlining variables, considering a more elegant way of writing; So relatively speaking, this falls under a 'temporary solution'.

If you have any ideas or suggestions, please make sure to raise them. We really need some discussion!

QJvic commented 7 months ago

Fixed In : 13377d3

Maybe this is not the best solution. For example, when we use datePicker and input in a same row, they have different height (the height of input box is 32px).

Yes, you are right. The CSS of some components is quite outdated. Although it has been refactored several times, the original code is about 3 years ago. You must have noticed, In the current structure, I have to explicitly set the height and width, which was a notion I didn't think would require so much compatibility when the project was just init. especially with "input-related" components such as select and datePicker, that they all have this kind of issue. But! We have relevant plans: #64

Non-essential : organizing all css, mainly streamlining variables, considering a more elegant way of writing; So relatively speaking, this falls under a 'temporary solution'.

If you have any ideas or suggestions, please make sure to raise them. We really need some discussion!

As far as this issue is concerned, I think it's more appropriate to set the overflow of the wrap box to hidden than to modify the height.

higuaifan commented 7 months ago

As far as this issue is concerned, I think it's more appropriate to set the overflow of the wrap box to hidden than to modify the height.

In some of my ancient memories, hiding inputs with overflow feels like "playing hooky", potentially causing issues in certain scenarios. However, I've tested several scenarios and it seems there are no problems. Anyway, your solution is better and more elegant; I fixed it.