Closed danielroe closed 5 months ago
Thank you for your PR!
command may neet to be changed to
npx nuxi@latest module add @shuimo-design/shuimo-ui-nuxt
But there will be such a prompt, is there any way to optimize it? Or is there something wrong with my usage of this command?
You can use either the npm package name or the slug in nuxt/modules: https://github.com/nuxt/modules/blob/main/modules/shuimo-ui.yml.
The prompt seems like maybe an issue with the packaging of the module (or a bug in nuxi
).
You can use either the npm package name or the slug in nuxt/modules: https://github.com/nuxt/modules/blob/main/modules/shuimo-ui.yml.
The prompt seems like maybe an issue with the packaging of the module (or a bug in
nuxi
).
π€ in nuxi
I found this line :
if (!pkgDependencies['nuxt'] && !pkgDependencies['nuxt-edge']) {
but like shuimo-nuxt
, dependencies like this:
{
"@nuxt/module-builder": "^0.5.5",
"@nuxt/kit": "^3.10.3",
"shuimo-ui": "workspace:^*"
}
I think a streamlined nuxt module
may not strict dependence nuxt
or nuxt-edge
,
although most of the time we dependence on nuxt
, but according to the documentation and some actual scenarios, @nuxt/kit
seems to be more common and necessary.
So how about adding @nuxt/kit
too?
Meanwhile, I've revisited the documentation carefully and noticed the mention of Module Types.
I wonder if it might be necessary to modify the logic for judgment to some extent?
For instance, should we prioritize checking for @nuxt
and @nuxtjs
?
Agreed π
π€ Nature of this PR
π Related Issue
π‘ Background and Solution
This updates the documentation to use the
nuxi module add
command which should simplify docs a bit and also improve user experience as there's no need to add tonuxt.config
manually.It's documented here.
I may have missed a few spots in the documentation as I'm doing this across the modules ecosystem assisted by the power of regular expressions β¨, so I'd appreciate a review π
β Pre-merge Checklist
βοΈPlease self-check and check all options.βοΈ