search

shy-neon / Favman

An app that allows you to easily change icons of your favorite sites on Safari
405 stars 11 forks source link

"Full" size icons? #24

Closed aayushbhatia06 closed 3 months ago

aayushbhatia06 commented 3 months ago

First of all, thank you for the great work on this software!

However I am facing an issue where no matter what I do I cant have a "full" size icon -

Screenshot 2024-08-25 at 6 37 48 PM

The D-Link icon is custom, I want it to take full space like all other icons but its not working. Any solutions? TIA

shy-neon commented 3 months ago

Thanks! Definitely something i have to pay attention to. Please, if it doesn’t bother you, upload the image so that i cant test this and fix it

aayushbhatia06 commented 3 months ago

Thank you for your prompt response!

For the icon I am using one named "Xiaomi Router" from https://macosicons.com/

Also forgot to mention in the original post but I am on the latest Seqouia dev beta if it makes any difference.

Thanks!

shy-neon commented 3 months ago

Hi! Basically safari handles how the icon looks by setting a parameter called “transparency analysis result”. There are 5 possible values, from 0 to 4. 0, 1 and 3 have clear effects (0 glass small and so on) 2 and 4 do the same thing as the other one, apparently.

Your icon has a clear padding around the solid background, I thought that (maybe) 2 or 4 could be the parameters to handle this case, but this is not the case.

Unfortunately this is inherently a behaviour of safari that cannot handle this kind of icons. Sadly there isn’t much i can do :(. If you like that icon you can remove the clear padding around it with preview, by cutting the image just around the blue background

Thanks for the downloading. You reassured me telling that it works fine on sequoia at least!

ND

aayushbhatia06 commented 3 months ago

Huh, very interesting! Thank you for taking the time to figure it out. I always download icons from that website (and its mentioned in this projects readme too) but I never really noticed the padding (although I always use them for desktop applications). Now that I know it is an easy fix. Thanks!