Open swayamvasavada opened 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
dev-find | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2024 2:30pm |
Thank you for the contribution but I am thinking it to migrate it to NextJS so I think this will be easy in that. If you want to contribute I will ping you after the migration or I can do it in the migration, what do you think?
Thank you for the contribution but I am thinking it to migrate it to NextJS so I think this will be easy in that. If you want to contribute I will ping you after the migration or I can do it in the migration, what do you think?
@shyamtawli
I strongly recommend merging this change, as it will be beneficial until the migration to Next.js is complete. Additionally, while migrating to Next.js, these changes will provide valuable support in the transition process.
Furthermore, I recommend considering a migration to the MERN stack instead of Next.js if backend support is a priority for you. Your consideration in merging this pull request and exploring alternative options is greatly appreciated. Thank you.
Description
This pull request addresses the issue regarding the dynamic addition of Developer profiles from the designated /data folder. By implementing this functionality, we aim to streamline the process for developers to include their profiles seamlessly. This enhancement not only simplifies the addition of new profiles but also ensures that the complexity of the system is effectively managed.
Key Improvements:
Related Issues
Enchaning issue #898
Changes Proposed
Dynamic Profile Addition: The modification in src/App.js allows for dynamic iteration through each file in the /data folder. This enables developers to effortlessly include their profiles without manual intervention, thereby enhancing the project's flexibility and scalability.
Relocation of Data Folder: To adhere to CRA standards and ensure consistent project structure, the data folder has been relocated from public/ to src/. This relocation maintains project integrity while simplifying file management and ensuring compatibility with React's build process.
Removal of ProfilesList.json: With the implementation of dynamic file iteration, the centralized file ProfilesList.json, which previously stored all file names for display purposes, is no longer necessary. This optimization reduces redundancy and streamlines the project's file structure.
Updated README.md: To reflect the changes in the process of adding developer profiles, the README.md file has been updated accordingly. This ensures that developers have access to accurate and up-to-date instructions for contributing to the project.
Checklist
Screenshots
Below images shows that after all these changes, The working and styling of style is as same as previous one.
Before:
After:
Note to reviewers