Ability to rotate screen without accelerometer

shyzus / gnome-shell-extension-screen-autorotate

Enable screen rotation regardless of touch mode

GNU General Public License v3.0

33 stars 10 forks source link

Ability to rotate screen without accelerometer #25

Closed shyzus closed 8 months ago

shyzus commented 8 months ago

See branch #12 .

Adds the ability to manually rotate the screen without an accelerometer being present.

This is disabled by default and requires to be enabled in the extensions preferences.

Adds a new indicator + quickmenutoggle to manually rotate the screen. Indicator when clicked will switch between landscape and portrait this should cover the basic usage of most gnome mobile users. There is a menu available on the indicator which allows the user to choose which orientation they wish to rotate to.

shyzus commented 8 months ago

Currently awaiting extensions.gnome.org review process for v16

shyzus commented 8 months ago

E.G.O review for v16 rejected:

JustPerfection rejected March 22, 2024

1. Timeout should be removed on disable (line 333 `extension.js`):

    [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)

2. I recommend to pass `this` from the entry point instead of using `lookupByUUID()` (line 66 `extension.js`).

shyzus commented 8 months ago

E.G.O review for v17 rejected:

JustPerfection rejected March 22, 2024

You have a typo in line 331 `extension.js` that won't let the timeout get cleaned up on disable:

```js
                          this._timoutId = setTimeout(() => {
// change to this._timeoutId
```

This is rather embarrassing but should be fixed in f6a65c48a0746b10cd67884f67fbbb9deefd468f

shyzus commented 8 months ago

E.G.O review for v18 accepted by JustPerfection.