search

sibartlett / homebridge-wink3

Homebridge plugin for wink.com
https://sibartlett.github.io/homebridge-wink3
ISC License
54 stars 20 forks source link

Offline Devices Not Showing as No Response #106

Closed mriksman closed 4 years ago

mriksman commented 6 years ago

I would have expected if a device is offline (two of my leakSMART sensors are offline, and JSON in Wink@Home shows connection:false) then in Home it should show as 'No Response'...? But it's not...

mriksman commented 6 years ago

Ahh. Simple fix. Need to change AccessoryHelper.js

  readAccessory(accessory, get, callback) {
    // First argument is current state
    // Second argument is desired state (merged state)
      const value = get(accessory.context.last_reading, accessory.merged_state);

    if (accessory.context.last_reading.connection)
       callback(null, value);
    else
       callback("no_response");
  }
jason-klein commented 5 years ago

The fix suggested by @mriksman worked correctly for me as well. See attached PR. Online devices still functioning normally, but bulbs that are offline now show NO RESPONSE. Before I applied this update locally, bulbs that were offline would show ON (100% Brightness).

sibartlett commented 4 years ago

Sorry, I am no longer actively maintaining this project. I am no longer using Wink, and do not have the time or resources to dedicate more to ongoing maintenance.