search

sickcodes / osx-serial-generator

Mac Serial Generator - Generate complete sets of Serial Numbers for OSX-KVM, Docker-OSX and of course, OpenCore.
GNU General Public License v3.0
1.57k stars 132 forks source link

Empty ROM data in config.plist #14

Closed ivankoma closed 2 years ago

ivankoma commented 2 years ago 
git clone https://github.com/sickcodes/osx-serial-generator
cd osx-serial-generator
./generate-unique-machine-values.sh -c 1 --model iMacPro1,1 --custom-plist=./config-custom.plist --bootdisks
grep -A 1 'ROM' ./plists/C02G20PDHX87.config.plist

Output:

                        <key>ROM</key>
                        <data></data>

In order to fix it change line 344 inside ./generate-unique-machine-values.sh

                ROM_VALUE="${MAC_ADDRESS//\:/}"
                ROM_VALUE="${ROM_VALUE,,}"
                sed -e s/\{\{DEVICE_MODEL\}\}/"${DEVICE_MODEL}"/g \
                    -e s/\{\{SERIAL\}\}/"${SERIAL}"/g \
                    -e s/\{\{BOARD_SERIAL\}\}/"${BOARD_SERIAL}"/g \
                    -e s/\{\{UUID\}\}/"${UUID}"/g \
-                   -e s/\{\{ROM\}\}/"${ROM"/g \
+                   -e s/\{\{ROM\}\}/"${ROM_VALUE}"/g \
                    -e s/\{\{WIDTH\}\}/"${WIDTH}"/g \
                    -e s/\{\{HEIGHT\}\}/"${HEIGHT}"/g \
./generate-unique-machine-values.sh -c 1 --model iMacPro1,1 --custom-plist=./config-custom.plist --bootdisks
grep -A 1 'ROM' ./plists/C02VP9Y4HX87.config.plist
                        <key>ROM</key>
                        <data>58b035aa47ef</data>
sickcodes commented 2 years ago

Thank you for this, will fix today!

sickcodes commented 2 years ago

This is interesting, it actually seems like it's not required.