search

sicpa-dlab / didcomm-rust

Apache License 2.0
28 stars 20 forks source link

Expanding test vectors #92

Open vongohren opened 2 years ago

vongohren commented 2 years ago

What

Give a brief description of the objective of this issue. What needs to be discussed?

Test vectors are not really testing different things. The test vectors currently only thinks about JWK methods. But your documentation have lots of different types.

I believe this lib should expand its test vectors to showcase more diversity of crypto

Why

Explain why you think this issue needs to be addressed and why it should be addressed in this repo.

Because it helps other people use this library more efficient as well and not hitting their heads against something that is supported but not documented

Success Criteria

Explain what actions or decisions need to be completed to close this issue.

  • Using a task list here can be helpful to track progress. Easy for newbies to start and see how they can do things with tests, to cater for their environment
brianorwhatever commented 2 years ago

Are there test vectors testing multibase encoded keys? ie. X25519KeyAgreement2020 and Ed25519VerificationKey2020

this would be a great place to start as I believe I encountered a bug see #95