search

side-codes / Android-Color-Picker

Color picker library for Android
https://side-codes.github.io/andColorPicker/
Apache License 2.0
313 stars 21 forks source link

[BUG] Saturation value not taken into account for Lightness bar updated via setPickedColor() #317

Closed plthatfunkymusic closed 4 months ago

plthatfunkymusic commented 4 months ago

When choosing a color via the 3 bars (H,S,L), I retrieve the current IntegerHSLColor and then use this to update each of the bars via setPickedColor(). Hue changes the S & L bar colors, but Saturation changes have no effect. So choosing zero for Saturation to give black <-> white should change the L bar to be just this, i.e. black on the left to white on the right. Instead it stays at whatever color the H bar is set to.

This doesn't affect the returned values, just the colour displayed on the L bar.

Apart from that, this library rocks. Many thanks!

plthatfunkymusic commented 4 months ago

Argh! Apologies. I've just realised that's the reason for the two output modes. Sorry