search

sidhartha9191 / yet-another-music-application

Automatically exported from code.google.com/p/yet-another-music-application
0 stars 0 forks source link

Milkdrop feature causes permanent Stoffi failure #187

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Try to install visualiser and error message pops up. Cancel.
2. Cancel many more error messages.
3. Stoffi returns back to normal.
4. Close Stoffi and reopen it.
5. Instant Stoffi crash, see screenshot. It is trying to load milkdrop on 
startup and fails. This should not happen as I cancelled all the error dialogs.
6. Uninstall Stoffi and reinstall.
7. Open Stoffi and it instantly crashes with the same message.
8. At this point, you will have to deal with support issues :)

What is the expected output? What do you see instead?
If the user attempts to load milkdrop, and it fails, Stoffi must fall back to 
the state where milkdrop is disabled, as it was before trying to switch the 
feature on.

I think you would agree that this is a blocker bug. 

Is there a away for me to fix my system manually?

What release of Stoffi are you using?
1.30

Original issue reported on code.google.com by wic...@gmail.com on 17 Mar 2011 at 6:51

Attachments:

GoogleCodeExporter commented 8 years ago 
You can fix this by opening C:\Users\<you>\AppData\Local\Brodd-Reijer\ 
...\user.config and change the value for EnableVisualizer to False.

I got this myself and will make Stoffi revert automatically.

Original comment by ephracis on 17 Mar 2011 at 11:03

GoogleCodeExporter commented 8 years ago 
Great, thank you for the solution.

Is it possible to suppress the error messages?

There are 4 in total, two messages repeated twice.

This is not essential, but could it make it in before stable?

Original comment by wic...@gmail.com on 18 Mar 2011 at 4:36

GoogleCodeExporter commented 8 years ago 
No, I have no control over those error messages. They are created by Windows 
and they occur only because the library that I use called BasViz.dll will try 
to load MilkDrop as a C++ module (because MilkDrop is a closed source library 
written in C++, so we have to use this hack).
Because BasViz loads an external dll during runtime (like a plugin) we have to 
make sure that it's OK with Windows (because of some security features). To do 
this I got the advice to run a command POST-compilation which is supposed to 
create a manifest which pretty much just tells Windows: "Hey, we want to run 
this and we assure that it's OK". At least that's what I've figured.

Problem is that for example the Installation packaging doesn't seem to get all 
that right (because when I create an Installation file it will compile Stoffi 
and put it all into an msi file). So for example if you install Stoffi for the 
first time you will get this error when you try to enable MilkDrop.

But I have noticed that an upgrade seemed to fix that, the upgrade contains a 
"pure" exe file that I have compiled by hand. But now this latest upgrade it 
broke again it seems.

My guess is that it could be solved if I recreate the manifest file and put 
that into the upgrade package as well, so when we upgrade the Stoffi exe file 
it will also update the manifest file. Maybe then the MilkDrop plugin will be 
able to run without Windows complaining.

Still have the problem with the Installation package but maybe there's a way 
around that one to.

I will see what I can do to get rid of the errors and make MilkDrop just a 
little bit more stable. At the very least I will make sure that Stoffi turns 
off visualizers if something goes wrong, just in case.
For some reason the scripts that are supposed to run over the MilkDrop dll file 
have not done their job.

Original comment by ephracis on 19 Mar 2011 at 2:14

GoogleCodeExporter commented 8 years ago

Original comment by ephracis on 6 Apr 2011 at 1:20

GoogleCodeExporter commented 8 years ago 
I have not been able to do any crash-detecting-code but according to my tests 
the latest release will not have this milkdrop crash at least.

Maybe we should add an issue for adding a crash detection thing. Some sort of 
smart recovery tool. Just in case Stoffi crashes. :)

Original comment by ephracis on 20 Apr 2011 at 6:33

GoogleCodeExporter commented 8 years ago

Original comment by ephracis on 20 Apr 2011 at 6:33

GoogleCodeExporter commented 8 years ago 
Please reopen this bug. The problem is much better, but the problem has morphed:

What is working?
1. Clicking Cancel does untick Enable Visualiser.

What is not working?
1. Click Ok, when it reads "Use at your own risk", to enable the visualiser.
2. Error dialog 1: "Failed to initialise DirectX 9.0. Click Yes to open the 
page in your default browser. See screenshot. 
3. Problem 1: Clicking Yes never opens the browser.
4. Error dialog 2: Error start VisModule. See screenshot.
5. The Enable Visualiser checkbox remains ticked.
6. Restart Stoffi. It does not crash, which is great. However the same error 
dialogs appear.
7. Problem 2: Go back to Preferences and Enable Visualiser has been unticked 
automatically. Milkdrop can't be switched off, as Stoffi has already unticked 
the checkbox.
8. Problem 3: Try to tick the box again, and it ticks and unticks the box by 
itself. 
9. Tick again, and the "Use at your own risk" dialog appears again. Now click 
Cancel, to try and turn Milkdrop off.
10. Restart Stoffi and Milkdrop has been switched off.

This is not intuitive. If you don't try and switch Milkdrop back on and then 
off, Milkdrop continues to load at startup, even though Stoffi unticked the 
checkbox automatically, in Step 7.

What is the expected output? What do you see instead?
Do not untick Milkdrop automatically. In this way, the user can simply go to 
Preferences, untick it and it will be switched off.

What release of Stoffi are you using?
1.30.325.1235

Original comment by wic...@gmail.com on 24 Apr 2011 at 8:11

GoogleCodeExporter commented 8 years ago 
I have decided that we need to hide this feature even more. I have no time to
hunt down these bugs so the GUI control is gone. It is still possible to enable
the visualizer but for that you need to dig into the user.config file. Hopefully
this will let me keep the visualizers for myself and you, but no one else will
know about it and so I don't need to care about the problems it may be causing.
This milkdrop thing has stolen enough time and energy from me already. We'll
create our own visualizer instead.

Original comment by ephracis on 24 Apr 2011 at 9:56

GoogleCodeExporter commented 8 years ago

Original comment by christof...@stoffiplayer.com on 24 Apr 2012 at 4:47