Promise connection sync methods always proxy non-pool connection

[c24w]

This is an issue when using a PromiseConnection which wraps a PoolConnection. For example:

const {createPool} = require('mysql2/promise');
const pool = await createPool(options);
const connection = await pool.getConnection();
connection.destroy();

destroy only ever proxies Connection.prototype.destroy, not PoolConnection.prototype.destroy, so the connection isn't removed from the pool.

[sidorares]

thanks. Would you be able to make unit test covering this?

[sidorares]

do you think #674 fixed this @c24w ?

[c24w]

@sidorares #674 fixed the exact issue I was seeing; however, this is the more generic issue that connections originating from a PromisePool are inheriting methods from Connection, not PoolConnection. My PR addressed this for the destroy method, but there may be others.