search

siemens / meta-iot2050

SIMATIC IOT2050 Isar/Debian Board Support Package
MIT License
131 stars 77 forks source link

refactor: use change-dir to split rootfs parts #531

Closed asrinuva closed 6 months ago

asrinuva commented 8 months ago

This patch refactors the WKS script w.r.t how the rootfs is distributed across multiple partitions. Previously we used rootfs-dir with a full rootfs paths plus the sub directory. However, this is not ideal, as the relation to the rootfs folder is lost and also the new rootfs dir is technically not a rootfs. While this aparently did not create any issues in meta-iot2050, we still believe it is semantically incorrect.

This patch switches that over to the WIC option --change-directory that is provided exactly for this use-case and only deploys a subdirectory without loosing the rootfs relation with the permissions pseudo dir.

asrinuva commented 8 months ago

@jan-kiszka Please have a look.

asrinuva commented 8 months ago

Can you please merge this changes if no objection.

jan-kiszka commented 8 months ago

I explained before that there is an upcoming release and that this is a cleanup, not a fix. I suspect it will only be merged afterwards.

asrinuva commented 8 months ago

I explained before that there is an upcoming release and that this is a cleanup, not a fix. I suspect it will only be merged afterwards.

Okay, thanks.