search

siemens / ros-sharp

ROS# is a set of open source software libraries and tools in C# for communicating with ROS from .NET applications, in particular Unity3D
Apache License 2.0
987 stars 373 forks source link

Update for openupm #427

Closed JohnClema closed 2 years ago

JohnClema commented 2 years ago

Issue

Currently I am trying to import ros-sharp's unity extensions as a distinct Unity package. This is not possible through a projects Package/manifest.json as ros-sharp is not published on a public registry.

Potential Solution

My thinking was potentially creating a package.json, and either publishing to npmjs.com (as this is the default package registry for unity) or publishing to openupm.com. Both are designed for this purpose.

This also updates the Unity3D folder to com.siemens.ros-sharp to match the package naming convention of Unity packages.

References: https://openupm.com/docs/ https://docs.unity3d.com/Manual/upm-manifestPrj.html

JohnClema commented 2 years ago

@MartinBischoff Any thoughts or comments would be much appreciated!

MartinBischoff commented 2 years ago

Hi @JohnClema , I totally agree. It absolutely makes sense to publish ROS# as Unity package. I haven't used openupm myself yet but the intro indicates that it is well suited for ROS#. Thank you for your initiative, your code changes and this merge request. I won't find time to contribute or test but I will merge this pull request when ready. If publishing should be done by myself, we can align via personal mail.