search

siesta-project / aiida_siesta_plugin

Source code for the AiiDA-Siesta package (plugin and workflows). See wiki
Other
6 stars 11 forks source link

Minor issues with setup.json pointed out by AiiDA registry #77

Closed ltalirz closed 4 years ago

ltalirz commented 4 years ago 
  >> WARNING: Missing classifier 'Framework :: AiiDA'
  >> WARNING: Entry point 'psf' does not start with 'siesta'
  >> WARNING: Entry point 'psml' does not start with 'siesta'
  >> WARNING: Entry point 'data.psf.family' does not start with 'siesta'
  >> WARNING: Entry point 'data.psml.family' does not start with 'siesta'

The first one should be easy to fix - for the others I would also suggest to think whether these entry points are really general enough not to be prefixed with siesta

bosonie commented 4 years ago

Hi @ltalirz. They are general enough and soon will be moved in the aiida-pseudo package. The first one will be addressed, but I won't make a release just for it.

ltalirz commented 4 years ago

Thanks @bosonie .

Just a comment: I haven't seen anyone else use the data prefix. It seems to me that psf.data/psml.data would seem more logical, but you can address this when the code moves to the aiida-pseudo package.

bosonie commented 4 years ago

Thanks for the comment @ltalirz. It will be "pseudo.family.psf". I will close this issue when I fix the 'Framework :: AiiDA'.