sifive / wake

The SiFive wake build tool
Other
86 stars 28 forks source link

rsc: Disallow hidden file dependencies #1649

Closed V-FEXrt closed 2 months ago

V-FEXrt commented 2 months ago

When a job creates both a file and a symlink to that file but only outputs the symlink it creates a hidden dependency on that untracked file.

This is generally not a huge problem but now is since the RSC is moving to only track true dependencies. The symlink would be restored but not the "hidden" file.

This PR panics when that situation occurs for a cached job. Broken jobs can avoid this by opting out of caching or by also outputting the hidden file