search

sifive / wake

The SiFive wake build tool
Other
86 stars 28 forks source link

cli: Add new history command #1667

Closed AbrarQuazi closed 2 weeks ago

AbrarQuazi commented 3 weeks ago

Added new wake --history command

AbrarQuazi commented 3 weeks ago

How the history command looks like. I used the default date time formatting from the Time library that we have for consistency, but if needed, I can change the formatting to something else like [Mon Nov 27 12:17:37 PST 2023] (but to do this new logic needs to be added to get the abbreviated days and month for processing as sqlite library doesnt do this out of the box)

Screenshot 2024-11-05 at 9 34 13 AM
colinschmidt commented 3 weeks ago

I used the default date time formatting from the Time library that we have for consistency

Where else do we print timestamps? I'm not sure we need the fancier formatting you mentioned but was thinking we could just drop the subsecond precision. Most wake invocations take longer than a second so I don't think we would lose any meaningful precision.

AbrarQuazi commented 3 weeks ago

Where else do we print timestamps

The only other time we use Time 's string function is for wake --script. Don't think subsecond is required for that right?

Screenshot 2024-11-05 at 1 34 36 PM
AbrarQuazi commented 3 weeks ago

e --timeline is zoomed in far enough (I think that's how it can be interacted with, right

I dont see --timeline really interacting with the --script command or calling Time's as_string() function