search

sifive / wit

Workspace Integration Tool
Apache License 2.0
23 stars 13 forks source link

Error on duplicate repo entries in manifest #221

Closed mmjconolly closed 4 years ago

mmjconolly commented 4 years ago

While looking at how to make wit init more parallel, I found a repo that has duplicate entries for a single repository at different commits: https://github.com/sifive/freedom-e-sdk/pull/463

This diff make it an error to do so.

richardxia commented 4 years ago

My only concern with this is that if some deeply nested repo has an invalid wit manifest file, you as a higher-level repo will not be able to do anything to deal with it, short of changing the low-level repo, which you may not have easy write access to.

Was freedom-e-sdk the only repo that you found with a duplicated manifest entry? If that's the case, then maybe this is fine, especially since @jackkoenig's recent changes to the Wit Scala plugin will also be a backwards-incompatible change anyway.