Open lucasrangit opened 3 years ago
sigma67
commented
3 years ago That is strange. How many videoIds do you have in l. 182 after running search_songs? You can add a breakpoint or debug print statement to find out. Perhaps also print out all the videoIds in case there is something strange going on.
lucasrangit
commented
3 years ago In main():
wc -l noresults_youtube.txt: 3
len(videoIds): 1584
Then in add_playlist_items() after OrderedDict.fromkeys(videoIds):
len(videoIds): 1512
YouTube Music playlist contains 1512.
I think it's either duplicate tracks or duplicate matches from songs that have similar names but different lengths? So maybe not an issue. I'll log the tracks names when there's a videoId "collision" and see if that's true.
lucasrangit
commented
3 years ago The Spotify playlist has duplicates (e.g. added from different region/language, or added by a different person). If I add the the number of missing and duplicate tracks I get what I expected.
Since duplicates will be matched to the same YouTube Music track, I suggest logging them in duplicates.txt file. Then you can easily see that if you add noresults_youtube.txt with duplicates.txt you get the number of YouTube Music playlist tracks. I'll make a PR for this to show you what I mean.
The alternative is to remove duplicates from the Spotify playlist when it's first retrieved. But there are other tools to do that (eg. https://github.com/stavlocker/SpotifyNoDupes) if necessary.
sigma67
commented
3 years ago Maybe I'm misremembering, but duplicates shouldn't be lost when transferring the playlist? If they are it would be a bug.
Edit: Nvm this is intentional behavior. Perhaps we should add a flag to include duplicates optionally, as it's not immediately apparent to the user
Hidroxiapatito
commented
9 months ago My issue is that my "noresults" file is generated but it's empty, and I expect there to be 9 tracks.
I'm using windows, running the "create" command from the "site-packages" folder. I had to rename main.py to main.py for it to work.
This happens with the "create" and "liked "commands (that I have tried so far). There are some tracks that are not found but don't appear in the "noresults" file. Examples of those are: 1. https://open.spotify.com/intl-es/track/0xMsn2VuXcfdf2Ksw4qz7G?si=53ba167f6cec4da2 Which should be found as: https://www.youtube.com/watch?v=mflNDS0tEOM&pp=ygURY29tcGFueSBzaXIgY2hsb2U%3D 2. https://open.spotify.com/intl-es/track/5UoCTv7xzBe9BytsuXxBqP?si=72c8c97b9735464f Which should be found as: https://youtu.be/mqps5JITgCI?si=7LehBYEDwWYLp4qH
Which now that I test them separately it seems that they get matched to the wrong song.
Reddax
commented
7 months ago I'm getting this same issue, but i'm missing songs that aren't dupes. Nothing in the noresults file
My Spotify playlist has 1587 tracks. The YouTube playlist created has 1511. However, the "noresults" file only contains 4. I expect there to be 76.
Note: the playlist is named "1587" (the number of tracks) for convenience as I validate the transfer.