search

signal-golang / textsecure

TextSecure(signal) client package for Go
GNU General Public License v3.0
57 stars 26 forks source link

Add support for Profile keys #37

Closed nanu-c closed 3 years ago

nanu-c commented 3 years ago

This adds support for profile keys. It's a first step for enabling avatars, profile names and groupsv2.

This has to be tested because it includes a rust library directly from Open whisper. The rust library is compiled to a shared library in c and then included with cgo. I have included precompiled shared object to the module to not break the build chains in the first place. But it would be better if the building is included in the ci.

For running anything with textsecure, the libzkgroup has to be placed in the LD_LIBRARY_PATH like export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD The corresponding error message is

error while loading shared libraries: libzkgroup_linux_amd64.so: cannot open shared object file: No such file or directory

Documentation can be improved a lot https://github.com/nanu-c/zkgroup

Should we add this to the Signal-golang organisation?

morph027 commented 3 years ago

If this is necessary for supporting groups v2 amongst others, we should add it.

We could add a makefile or some scripts to execute all necessary build steps.