search

signalapp / Signal-Android

A private messenger for Android.
https://signal.org
GNU Affero General Public License v3.0
25.51k stars 6.11k forks source link

Signal sends notifications of my own messages when sent from notification or google auto #12466

Closed micw closed 1 year ago

micw commented 2 years ago

Bug description

When I answer a message within the notification popup, I get a notification a few seconds later, containing my own answer.

When I answer a message via google auto, I get a notification a few seconds later, containing my own answer (I guess i't related and i guess google auto uses the "notification direct answer" function for this feature).

Steps to reproduce

Actual result: The message is sent. After a few seconds, my own message is notified as incoming/new message. Expected result: The message should be send but not notified back to myself.

Screenshots

Device info

Device: OnePlus 6 Android version: 11 Signal version: 5.49.4

Link to debug log

alex-signal commented 2 years ago

Hi! Could you please add a debug log? We recently did some work around the replies functionality with Android Auto in this area.

micw commented 2 years ago

Hello, thank you for the fast response. Honestly, it's a few weeks ago that I used this functionality because of this bug. So the Signal version I reported may not be the correct one if there was a recent update. I did a test with Android Auto today and did not receive my own messages anymore. I will do another test with normal notification reply (without android auto) as soon as I receive another message.

I will come back with new test results and will close the issue if it's already solved.

micw commented 2 years ago

I did several tests with "inline" reply in notifications. The behaviour has changed. I now get the notification for the incoming message again, when I answer. I can verify this because I receive all signal notifications on my MI Band.

alex-signal commented 2 years ago

Thanks! Could you please add a debug log? I'll ensure we're tracking this and have someone take a look

micw commented 2 years ago

Sure. How can I do this?

alex-signal commented 2 years ago

https://support.signal.org/hc/articles/360007318591-Debug-Logs-and-Crash-Reports#android_debug

micw commented 2 years ago

Will the debug log contain info from start of the app/phone or a certain time range? (because i did the tests yesterday and rebootet the phone meanwhile)? Will it contain messages or other personal information?

alex-signal commented 2 years ago

We scrub out personal information. Debug logs generally contain the last few days worth of data, depending on how much you use the app. I think they cap out around 7 days unless we explicitly mark log lines as "long term" which last 21 days. These are of course used sparingly.

micw commented 2 years ago

A debug log, taken shortly after the issue (received notification of the message I answered to) happened. https://debuglogs.org/android/5.49.4/df9034229dd7af2d70fa4090ea942f2f178c1292e0f57e65962b43d574ec1bcd

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

greyson-signal commented 1 year ago

Reading through this, I think this is just how google handles inline notification replies, which is how google auto replies are handled. I don't think there's much for us to do here, sorry!

micw commented 1 year ago

Are you sure about this or is this just a guess? Would it make sense to gather more information (e.g. verify if other apps behave the same) rather than just closing the issue? Let me know what tests/infos you need to track it down or ensure that this is really not solvable.

Kind regards, Michael.

micw commented 1 year ago

Update: I just got a brief test:

Signal

Telegram: